Skip to content

confirmation prompt text can now be customized#1786

Merged
davidism merged 1 commit into
pallets:masterfrom
MLH-Fellowship:custom-confirm-prompt
Feb 25, 2021
Merged

confirmation prompt text can now be customized#1786
davidism merged 1 commit into
pallets:masterfrom
MLH-Fellowship:custom-confirm-prompt

Conversation

@Saif807380

Copy link
Copy Markdown
Contributor

The user can now customize the confirmation prompt text. If confirmation_prompt is set to True, the default prompt text will be used. If a non-empty string is provided then that will be used.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
davidism force-pushed the custom-confirm-prompt branch from 4422ed8 to 4177587 Compare February 25, 2021 01:03
@davidism davidism added this to the 8.0.0 milestone Feb 25, 2021
@davidism
davidism force-pushed the custom-confirm-prompt branch from 4177587 to 06aa862 Compare February 25, 2021 01:06
@davidism
davidism merged commit 1b1578d into pallets:master Feb 25, 2021
@davidism
davidism deleted the custom-confirm-prompt branch February 25, 2021 01:09
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable "Repeat for confirmation:" text

2 participants