You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@kdeldycke Thanks for the double check. How did you spot this?
Because I just remembered the last time I had to do the main <-> stable dance I had to painfully reconcile the two. Remember #3508 ? 😁 So when I just saw you playing with the branches and other tickets being changed their milestone, I was pretty sure something was dropped along the way. Just my instincts. So I compared the code in both branches and found the discrepancy.
But yeah, something is probably wrong in the way we sync or manage our branches as this is not the first time this happens. In my projects I just have a main and if I need a hotfix, I just branch the last tagged release, create a new release from that and reconcile the history by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3674 to push split of
test_utils.py, a test change in #3505 while dropping Colorama has been lost.This restore it.
See recent @Rowlando13
main<->stabledance in: