docs: fix wrong Request attribute for MAX_FORM_MEMORY_SIZE - #6117
Closed
latent-9 wants to merge 1 commit into
Closed
docs: fix wrong Request attribute for MAX_FORM_MEMORY_SIZE#6117latent-9 wants to merge 1 commit into
latent-9 wants to merge 1 commit into
Conversation
The MAX_FORM_MEMORY_SIZE entry cross-references `.Request.max_form_memory_parts`, which does not exist. The per-request attribute for this limit is `max_form_memory_size` (its default 500_000 matches this entry). The neighbouring entries follow the same convention (MAX_CONTENT_LENGTH -> max_content_length, MAX_FORM_PARTS -> max_form_parts).
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MAX_FORM_MEMORY_SIZEconfig entry indocs/config.rstcross-references:attr:.Request.max_form_memory_parts``, but there is nomax_form_memory_partsattribute on the request. The per-request attribute for this limit is `max_form_memory_size` (Werkzeug's `Request.max_form_memory_size`, whose default `500_000` matches this entry's documented default).The neighbouring config entries follow the same
.Request.<lowercased config name>convention:MAX_CONTENT_LENGTH->.Request.max_content_lengthMAX_FORM_PARTS->.Request.max_form_partsSo
MAX_FORM_MEMORY_SIZEshould reference.Request.max_form_memory_size. Fixed the attribute name.