fix: prevent broken pipe from bypassing CRC start retry logic#109
Merged
Conversation
- The retry pattern check used echo "$start_output" | grep which caused a SIGPIPE with pipefail, killing the script before retries could execute. Read the log file directly with grep instead. - Added "Failed to update pull secret" to retryable error patterns. - Made GitHub API connectivity check truly non-fatal with a separate check_optional_service function (5 retries, warns but never fails).
sebrandon1
force-pushed
the
fix-retry-broken-pipe
branch
from
July 16, 2026 20:52
f2a9ca7 to
e596e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo "$start_output" | grepcaused a SIGPIPE underset -eo pipefail, killing the script before CRC start retries could execute. Replaced withgrep ... "$start_log"to read the log file directly.Failed to update pull secretto retryable error patterns (seen in nightly run 29528128170).start_outputvariable.Context
In the latest nightly run, 13/14 jobs passed. The single failure (
ubuntu-24.04, 4.21) hit a retryable SSH error during CRC start, but the retry logic was bypassed because the pipe broke before the grep could complete. This fix ensures retries work correctly regardless of CRC output size.Test plan
make lintpasses