type Index view and drop #1518
Open
type Index view and drop #1518
+61
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
requested changes
Dec 1, 2025
cmp0xff
requested changes
Dec 1, 2025
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
Co-authored-by: Yi-Fan Wang <cmp0xff@users.noreply.github.com>
cmp0xff
reviewed
Dec 2, 2025
tests/indexes/test_indexes.py
Outdated
Comment on lines
1684
to
1686
| check(assert_type(ind.view(np.ndarray), np_ndarray), np.ndarray) # type: ignore[assert-type] | ||
| else: | ||
| check(assert_type(ind.view(np.ndarray), np_ndarray), np.ndarray) # type: ignore[assert-type] # pyright: ignore[reportAssertTypeFailure] |
Contributor
There was a problem hiding this comment.
I think we should resolve some of the ignores here, but I cannot see how. Any idea @Dr-Irv @loicdiridollou ?
Collaborator
There was a problem hiding this comment.
This is some issue with how mypy is interpreting the numpy types, which are better in numpy 2.x than in numpy 1.x.
So if mypy is failing on this, so be it.
Reported python/mypy#20354
Contributor
There was a problem hiding this comment.
Thank you @Dr-Irv !
@MarcoGorelli , you have added the following overload:
@overload
def view(self, cls: type[NDArrayT]) -> NDArrayT: ...so if you do ind.view(np.ndarray), it seems reasonable to me to get np.ndarray as the resulting type, instead of getting np_ndarray. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1485
assert_type()to assert the type of any return value)AGENTS.md.