Backport PR #46119 on branch 1.4.x (REF: isinstance(x, int) -> is_integer(x)) #46501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Alternative to #46500, is to backport and follow-up with a test and release note. As this is not atomic, personally I prefer the revert and redo option. |
simonjayhawkins
added
Regression
Contributor
|
I think either might work, i probably prefer just the add tests and whats new option personally due to simplicity. |
Contributor
|
I think this PR is fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #46119: REF: isinstance(x, int) -> is_integer(x)