Conversation
Adds es6 support for arrow function syntax
feature(conceal): add prototype to the list of conceals
The latest documentation for JSDoc3 use lowercase tags (http://usejsdoc.org/), but the oldest versions may use camel case (see https://code.google.com/p/jsdoc-toolkit/wiki/TagReference). The current syntax supports both of them.
See documentation http://usejsdoc.org/tags-tutorial.html.
Each of the following character classes contains an escaped "]":
/[\]]/
/[\]x]/
/[\\\]]/
The following character class does *not* contain an escaped "]":
/[\\]/
string: spell-check string literals
Adds es6 support for rest parameters in function signatures
Most significantly, this causes shorthand character classes within
groups to be highlighted. For example:
/(\d)/
regexp: add jsSpecial to jsRegexpSpecial cluster
The intention of this commit is to perhaps improve performance, but also clean up a bit of the how a couple regexes are used. By adding `contained` to `jsObjectKey`, I think we might get a nice performance boost, especially on larger files since it won't attemp that lookbehind everywhere. Adding `contained` to the newer regex for string templating stuff in ES6 seems more 'accurate' or proper.
Adding additional `contained`s
For some reason a whole group of regexes where indented 2 space. Not sure why, perhaps a holdover from some other era of whitespace organization. Anyays, pulling it back for now. This is a purely aesthetic/cleanup commit, nothing major.
Fixing odd indentation levels in syntax file
Collaborator
Author
|
I am a bit behind in getting this merged in, but I'd like to merge this tonight. Any potential objections from any other collaborators? Last call. |
Collaborator
|
No objections here. |
Collaborator
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while since the
developbranch has been merged into master. Setting up this PR now for people to identify any bugs or issues withdevelopbefore we merge it intomaster.I was thinking we can merge this in sometime this weekend, giving ample time to find any potential glaring issues.
I've been running the
developbranch for a while now with no real issues, so it's really these few PRs that got merged in today that need to be tested.