Skip to content

Conversation

@valeriangalliat
Copy link

I noticed a bug with syntax highlighting of comments inside ES6 classes:

screen shot 2016-04-19 at 1 45 40 pm

screen shot 2016-04-19 at 1 45 51 pm

This was "introduced" since class support #354, which have a very strict definition (not including @jsAll).

This PR adds support for comments inside ES6 classes:

screen shot 2016-04-19 at 1 50 05 pm

screen shot 2016-04-19 at 1 50 16 pm

@amadeus
Copy link
Collaborator

amadeus commented Apr 19, 2016

This PR needs to be opened up against develop, but I actually had a branch ready to open a PR for this so I'll just go ahead and get that in. Thanks for letting us know tho!

@amadeus amadeus closed this Apr 19, 2016
@amadeus
Copy link
Collaborator

amadeus commented Apr 19, 2016

I have merged a fix into the develop branch for this, thanks again!

@valeriangalliat
Copy link
Author

Cool, thx!

@valeriangalliat valeriangalliat deleted the es6-classes-comments branch April 19, 2016 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants