fix(auto-approve): use hmarr/auto-approve-action instead of a deleted local action - #38
Merged
Conversation
… local action Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: panicboat <panicboat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto-approve PRsが全 PR で失敗していた。.github/workflows/auto-approve.yamlがローカル action./auto-approveを参照しているが、そのディレクトリは #2(Remove old action directories and update README)で削除済みだった。ワークフロー側の更新漏れ。削除前の
auto-approve/action.yamlはhmarr/auto-approve-actionによるレビュー承認と、automergeラベルが付いた PR のgh pr merge --squash --autoを行う composite action だった。現在automergeラベルを持つ PR は無い(gh pr list --state all --json labelsで確認)ため、auto-merge 機能を落としても現行の挙動には影響しない。What
platform/monorepoと同じ構成(hmarr/auto-approve-actionを直接呼ぶ)に揃えた。auto-merge のステップは持ち込んでいない。あわせて、同一 App (
panicboat-ci-bot) が作成した PR を自己承認しようとして 422 で失敗する既知の問題(hmarr/auto-approve-actionが installation token の identity をGET /userの 403 から"github-actions[bot]"と決め打ちする副作用、ソース)も先取りして回避した。renovate PR(現状の主な PR 発生源)は別 App のため影響しない。同一原因の修正を panicboat/platform#810、panicboat/monorepo#994 でも行っている。
🤖 Generated with Claude Code
https://claude.ai/code/session_01FJMY2CQPbJLzu5daCKMuM5