Skip to content

Update Domain dependency to 2.0.1 - #3

Merged
PANiXiDA merged 1 commit into
mainfrom
feature/update-domain-2.0.1
Jul 28, 2026
Merged

Update Domain dependency to 2.0.1#3
PANiXiDA merged 1 commit into
mainfrom
feature/update-domain-2.0.1

Conversation

@PANiXiDA

Copy link
Copy Markdown
Contributor

Что изменено

  • PANiXiDA.Core.Domain обновлён с 1.0.4 до 2.0.1.
  • Тестовый aggregate переведён на readonly record struct идентификатор с IStronglyTypedId.

Зачем

Domain 2.0.1 требует Guid-backed strongly typed identifiers для entity и aggregate root.

Как проверить локально

  • dotnet restore PANiXiDA.Core.Application.slnx
  • dotnet format PANiXiDA.Core.Application.slnx --no-restore --verify-no-changes
  • dotnet build PANiXiDA.Core.Application.slnx --configuration Release --no-restore
  • dotnet test PANiXiDA.Core.Application.slnx --configuration Release --no-build --no-restore — 47 passed
  • dotnet pack src/PANiXiDA.Core.Application/PANiXiDA.Core.Application.csproj --configuration Release --no-build --no-restore

Совместимость

  • Миграции и изменения конфигурации отсутствуют.
  • Публичный API Application не изменён, но пакет теперь требует Domain 2.0.1 с его breaking-контрактом strongly typed identifiers.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b4a50e6157

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Directory.Packages.props
<PackageVersion Include="FluentValidation" Version="12.1.1" />
<PackageVersion Include="Nerdbank.GitVersioning" Version="3.9.50" />
<PackageVersion Include="PANiXiDA.Core.Domain" Version="1.0.4" />
<PackageVersion Include="PANiXiDA.Core.Domain" Version="2.0.1" />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Document the new identifier requirement

When an existing consumer upgrades to the package produced with this dependency, Domain 2.0.1 requires strongly typed identifiers, as evidenced by the necessary replacement of AggregateRoot<Guid> in this diff. The README still presents only .NET 10 and nullable annotations as requirements, so users with Guid-based aggregate roots receive an undocumented breaking compile-time migration; update its requirements or migration guidance to describe the new identifier contract.

AGENTS.md reference: AGENTS.md:L58-L64

Useful? React with 👍 / 👎.

@PANiXiDA
PANiXiDA merged commit d3c127a into main Jul 28, 2026
4 checks passed
@PANiXiDA
PANiXiDA deleted the feature/update-domain-2.0.1 branch July 28, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants