Update Domain dependency to 2.0.1 - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4a50e6157
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageVersion Include="FluentValidation" Version="12.1.1" /> | ||
| <PackageVersion Include="Nerdbank.GitVersioning" Version="3.9.50" /> | ||
| <PackageVersion Include="PANiXiDA.Core.Domain" Version="1.0.4" /> | ||
| <PackageVersion Include="PANiXiDA.Core.Domain" Version="2.0.1" /> |
There was a problem hiding this comment.
Document the new identifier requirement
When an existing consumer upgrades to the package produced with this dependency, Domain 2.0.1 requires strongly typed identifiers, as evidenced by the necessary replacement of AggregateRoot<Guid> in this diff. The README still presents only .NET 10 and nullable annotations as requirements, so users with Guid-based aggregate roots receive an undocumented breaking compile-time migration; update its requirements or migration guidance to describe the new identifier contract.
AGENTS.md reference: AGENTS.md:L58-L64
Useful? React with 👍 / 👎.
Что изменено
PANiXiDA.Core.Domainобновлён с1.0.4до2.0.1.readonly record structидентификатор сIStronglyTypedId.Зачем
Domain 2.0.1требует Guid-backed strongly typed identifiers для entity и aggregate root.Как проверить локально
dotnet restore PANiXiDA.Core.Application.slnxdotnet format PANiXiDA.Core.Application.slnx --no-restore --verify-no-changesdotnet build PANiXiDA.Core.Application.slnx --configuration Release --no-restoredotnet test PANiXiDA.Core.Application.slnx --configuration Release --no-build --no-restore— 47 passeddotnet pack src/PANiXiDA.Core.Application/PANiXiDA.Core.Application.csproj --configuration Release --no-build --no-restoreСовместимость
Applicationне изменён, но пакет теперь требуетDomain 2.0.1с его breaking-контрактом strongly typed identifiers.