Skip to content

Remove post_stats from RunTracker#11068

Merged
gshuflin merged 2 commits intopantsbuild:masterfrom
gshuflin:kill-more-runtracker-code
Oct 28, 2020
Merged

Remove post_stats from RunTracker#11068
gshuflin merged 2 commits intopantsbuild:masterfrom
gshuflin:kill-more-runtracker-code

Conversation

@gshuflin
Copy link
Contributor

This is more RunTracker code that is no longer used and can be removed entirely.

[ci skip-rust]

[ci skip-build-wheels]
[ci skip-rust]

[ci skip-build-wheels]
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling 3289dcb on gshuflin:kill-more-runtracker-code into 0a04bbc on pantsbuild:master.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@asherf
Copy link
Member

asherf commented Oct 28, 2020

the corresponding options should also be removed in this PR.
probably along with the basic auth subsystem.

@gshuflin gshuflin merged commit 9813237 into pantsbuild:master Oct 28, 2020
@gshuflin gshuflin deleted the kill-more-runtracker-code branch October 28, 2020 18:21
gshuflin added a commit that referenced this pull request Oct 28, 2020
The only pants code using this functionality was RunTracker, and now that #11068 has removed RunTracker's dependency on `auth`, everything in that module can be removed other than the option deprecations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants