Clarify that process cache namespacing works for all runners#11095
Merged
stuhood merged 2 commits intopantsbuild:masterfrom Nov 5, 2020
Merged
Clarify that process cache namespacing works for all runners#11095stuhood merged 2 commits intopantsbuild:masterfrom
stuhood merged 2 commits intopantsbuild:masterfrom
Conversation
…ess_execution_cache_namespace`, because it applies to all runners. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Nov 5, 2020
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Nov 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
remote_execution_process_cache_namespaceoption affects all runners (rather than just the remote runner), so it is misnamed.Solution
Rename the option to
process_execution_cache_namespace, and deprecate the old option.[ci skip-rust]
[ci skip-build-wheels]