Fix --log-levels-by-target not working for logs from Python code (Cherry-pick of #13939))#13941
Merged
Eric-Arellano merged 1 commit intopantsbuild:2.8.xfrom Dec 21, 2021
Merged
Conversation
…antsbuild#13939) Fixes pantsbuild#13938. The problem is as I suspected in the issue. The logging level was being set globally in Pythonland, and if the log-call level was < the global level, we never entered Rustland to consider `log_levels_by_target`. --- Using `./pants_from_sources --stats-log ...` on my repo I see: ``` level = "warn" log_levels_by_target = {"pants.goal.stats_aggregator" = "info"} ``` DOES print the stats (`INFO`). Previously it would not. and additionally (to test inversion) ``` level = "debug" log_levels_by_target = {"pants.goal.stats_aggregator" = "warn"} ``` DOES NOT print the stats (`INFO`) # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
thejcannon
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13938.
The problem is as I suspected in the issue. The logging level was being set globally in Pythonland, and if the log-call level was < the global level, we never entered Rustland to consider
log_levels_by_target.Using
./pants_from_sources --stats-log ...on my repo I see:DOES print the stats (
INFO). Previously it would not.and additionally (to test inversion)
DOES NOT print the stats (
INFO)Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]