Remove the deprecated implicit_value option kwarg.#20762
Merged
benjyw merged 4 commits intopantsbuild:mainfrom Apr 8, 2024
Merged
Remove the deprecated implicit_value option kwarg.#20762benjyw merged 4 commits intopantsbuild:mainfrom
benjyw merged 4 commits intopantsbuild:mainfrom
Conversation
Now the only implicit value is "True" for boolean options (that is, --foo is the same as --foo=true).
Contributor
Author
|
See #20757 for context |
thejcannon
approved these changes
Apr 6, 2024
huonw
approved these changes
Apr 7, 2024
| # Validate kwargs. | ||
| deprecated_conditional( | ||
| lambda: "implicit_value" in kwargs, | ||
| removal_version="2.21.0a0", |
Contributor
There was a problem hiding this comment.
Just noting that I could imagine we do one two more 2.21.0.devX releases before a0 (hopefully not, though!), so this removal_version might end up being a slight fib. Fine by me, though, given we theorise it's unlikely people are using this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the only implicit value is "True" for boolean
options (that is, --foo is the same as --foo=true).