Skip to content

Remove the unused WrappedGenerateLockfile dataclass.#23271

Merged
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:kill_wrapped_generate_lockfile
Apr 18, 2026
Merged

Remove the unused WrappedGenerateLockfile dataclass.#23271
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:kill_wrapped_generate_lockfile

Conversation

@benjyw
Copy link
Copy Markdown
Contributor

@benjyw benjyw commented Apr 18, 2026

Nothing creates it or consumes it. I don't even know
what it was supposed to be for.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Apr 18, 2026
@sureshjoshi
Copy link
Copy Markdown
Member

Net negative PR? Sign me up.

Was this for any sort of 3rd party external stuff? A cursory Github search doesn't surface anything other than test_filter_tool_lockfile_requests in generate_lockfiles_test.py that no longer exists.

e9946d3#diff-0cffb7c120675838a94ad3c3546e9540500a61836401586c8f8982fc30aaa057

@benjyw benjyw merged commit 0283af6 into pantsbuild:main Apr 18, 2026
25 checks passed
@benjyw benjyw deleted the kill_wrapped_generate_lockfile branch April 18, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants