Skip to content

Fix pex_venv_test.py#23288

Merged
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:fix_pex_venv_test
Apr 22, 2026
Merged

Fix pex_venv_test.py#23288
benjyw merged 1 commit intopantsbuild:mainfrom
benjyw:fix_pex_venv_test

Conversation

@benjyw
Copy link
Copy Markdown
Contributor

@benjyw benjyw commented Apr 22, 2026

Several of the tests in that file use psycopg2-binary as
a test requirement. Previously it used version 2.9.6, which
is not compatible with Python 3.14 on macos.

This change upgrades to psycopg2-binary==2.9.12,
so that the test passes on macos.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Apr 22, 2026
Copy link
Copy Markdown
Member

@sureshjoshi sureshjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason that it uses that one? Is it because it's a binary requirement specifically?

Whenever I want to have grief, I use psycopg2...

@benjyw
Copy link
Copy Markdown
Contributor Author

benjyw commented Apr 22, 2026

I think it is exactly for the grief - or more specifically because it involves prebuilt native code, so it has platform-specific wheels.

@benjyw benjyw merged commit 8743288 into pantsbuild:main Apr 22, 2026
25 checks passed
@benjyw benjyw deleted the fix_pex_venv_test branch April 22, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants