Fix the dynamic UI.#23306
Merged
benjyw merged 1 commit intopantsbuild:mainfrom May 2, 2026
Merged
Conversation
In pantsbuild#23114 we upgraded to indicatif 0.18.4, which included a fix to respect TERM=dumb, or no TERM at all, as well as respecting NO_COLOR. Since we did not pass TERM through pantsd, the dynamic ui was not shown. This change fixes that.
benjyw
added
needs-cherrypick
Contributor
Author
|
AI disclosure: Gotta hand this one to Claude. It figured out the cause by introspection, and manual experiment confirmed it. |
Contributor
Author
|
Note that this bug didn't make it into any releases, so does not need mentioning in release notes. |
sureshjoshi
approved these changes
May 2, 2026
Member
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.32.xSuccessfully opened #23308. Thanks again for your contributions! |
benjyw
added a commit
that referenced
this pull request
May 2, 2026
In #23114 we upgraded to indicatif 0.18.4, which included a fix to respect TERM, and display nothing if it's unset. Since we did not pass TERM through pantsd, the dynamic ui is now not shown. This change fixes that, and also pass NO_COLOR through, since indicatif inspects it too. Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #23114 we upgraded to indicatif 0.18.4,
which included a fix to respect TERM, and
display nothing if it's unset.
Since we did not pass TERM through pantsd, the
dynamic ui is now not shown.
This change fixes that, and also pass NO_COLOR
through, since indicatif inspects it too.