Skip to content

Differentiate types of git changes#23309

Merged
benjyw merged 2 commits intopantsbuild:mainfrom
benjyw:git_change_types
May 4, 2026
Merged

Differentiate types of git changes#23309
benjyw merged 2 commits intopantsbuild:mainfrom
benjyw:git_change_types

Conversation

@benjyw
Copy link
Copy Markdown
Contributor

@benjyw benjyw commented May 3, 2026

When interrogating git to compute --changed-*
specs, we now record the type of git change
(add, modify, delete).

We don't yet do anything with this information.
This is initial work towards fixing #17512/#23240.

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label May 3, 2026
@benjyw benjyw requested review from cburroughs and tdyas May 3, 2026 15:53
Comment thread src/python/pants/vcs/git.py
Comment thread src/python/pants/vcs/change.py Outdated
Comment thread src/python/pants/vcs/git.py
@benjyw benjyw requested a review from tdyas May 4, 2026 04:08
@benjyw benjyw merged commit 9c1c4c4 into pantsbuild:main May 4, 2026
25 checks passed
@benjyw benjyw added this to the 2.32.x milestone May 4, 2026
@WorkerPants
Copy link
Copy Markdown
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

✔️ 2.32.x

Successfully opened #23313.


Thanks again for your contributions!

🤖 Beep Boop here's my run link

benjyw added a commit that referenced this pull request May 5, 2026
When interrogating git to compute `--changed-*`
specs, we now record the type of git change 
(add, modify, delete).

We don't yet do anything with this information.
This is initial work towards fixing #17512/#23240.

Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
@benjyw benjyw deleted the git_change_types branch May 5, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants