refactor: Parse BUILD-files once#23394
Open
tobni wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for looking at this and the multi-parse has bothered me every time I looked at it. I'm struggling to find my prior notes, but when I tried this it was counterintuitively slower on whatever I tried it with, presumably because |
Contributor
Author
|
This change is within noise wallclock but does reduce total cpu, mostly due to reduced allocations. It scales with number of build files and symbols therein. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was a theoretical cold-start performance gain that turned out to be minor. I do think this is cleaner though.