Fix: Defer validate_resolved_files in hydrate_sources to support …#23465
Open
thiago-carbonera wants to merge 1 commit into
Open
Fix: Defer validate_resolved_files in hydrate_sources to support …#23465thiago-carbonera wants to merge 1 commit into
validate_resolved_files in hydrate_sources to support …#23465thiago-carbonera wants to merge 1 commit into
Conversation
…generated SingleSourceFields Fixes pantsbuild#23015 Signed-off-by: Thiago Riemma Carbonera <thiagoriemma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23015
Problem
SingleSourceFields that rely on target generation/codegen currently fail to hydrate. This happens becausevalidate_resolved_filesis called immediately after glob expansion, before the actual code generation (generate_sources) takes place. SinceSingleSourceFieldstrictly expects exactly 1 file, this premature validation fails because the generated file doesn't exist yet.Solution
Refactored the execution order inside
hydrate_sources(src/python/pants/engine/internals/graph.py) to defer file validation:snapshotas before.generated_sources.snapshot.filesafter thegenerate_sourcesawait completes.Also added the corresponding release note to
docs/notes/2.33.x.md.