[trigger ci] some ivy work in progress#2884
Closed
baroquebobcat wants to merge 48 commits into
Closed
Conversation
…ethod I've convinced myself that loading the classpath doesn't need to be under the lock
…f other tests though
…ut the values live in a different place
Before it was setting _options, but that didn't change the instances that had already been created which meant that setting options was implicitly kept across executions, so you couldn't call execute, then change options then call execute again
…nstead of frozen resolve dict in fetch ivy gen
…e for bundle test
3 tasks
tdyas
pushed a commit
that referenced
this pull request
May 19, 2026
…) (regression from #22906) (#23341) Disclaimer: I used Claude Code to evaluate and confirm comments from #23328. Basically, part of #22906 needs to be reverted. Okay, now here's Claude: ## Summary Fixes a `KeyError` regression introduced by #22906 that breaks `pants check` (and other JVM goals) on lockfiles whose entries reference a transitive dependency that has no top-level coord entry of its own. #22906 bumped Coursier to v2.1.24 to pick up the fix for [coursier#2884](coursier/coursier#2884) and, on the assumption that the only remaining "missing entry" cases would be parent POMs (`classifier="pom"`), simplified `CoursierResolvedLockfile.dependencies()` to do a direct dict lookup instead of an `entries.get(...)` guard. That assumption turns out to be wrong: even fresh resolves with the latest Coursier (verified against v2.1.25-M19) still emit transitive deps without a coord entry — e.g. `("org.apache.curator", "apache-curator", None)` when resolving `org.apache.hive:hive-exec:1.1.0`, or `("org.apache.arrow", "arrow-memory", None)` in the user-reported repro on `hive-exec:3.1.3`. Both have `classifier=None`, so the `if d.classifier != "pom"` filter doesn't catch them, and the unguarded lookup raises `KeyError`. This restores the pre-#22906 `entries.get(...)` skip and adds the bug-report repro as a regression test. ## Changes - `src/python/pants/jvm/resolve/coursier_fetch.py`: restore the `entries.get(...)` guard in `dependencies()`; update the comment to reflect that #2884-style missing entries are still observable on current Coursier. - `src/python/pants/jvm/resolve/coursier_fetch_test.py`: add `test_dependencies_skips_transitive_entries_missing_from_lockfile` — the exact fixture from the bug report. Without the fix it reproduces `KeyError: ('org.apache.arrow', 'arrow-memory', None)`; with the fix it passes. ## Out of scope - `CoursierResolvedLockfile.direct_dependencies()` has the same unguarded pattern but predates #22906; leaving for a follow-up PR. - The longer-term transitive-closure rewrite drafted in `plans/20251117_jvm_transitive_dep_bug.md` is also a follow-up. ## Test plan - [x] New unit test `test_dependencies_skips_transitive_entries_missing_from_lockfile` passes with the fix and fails (with the original `KeyError`) without it. - [x] `./pants test src/python/pants/jvm/resolve/coursier_fetch_test.py src/python/pants/jvm/resolve/coursier_fetch_integration_test.py` — all pass. - [x] `./pants fmt lint check` clean on both changed files.
This was referenced May 19, 2026
tdyas
pushed a commit
that referenced
this pull request
May 20, 2026
…) (regression from #22906) (Cherry-pick of #23341) (#23359) Disclaimer: I used Claude Code to evaluate and confirm comments from #23328. Basically, part of #22906 needs to be reverted. Okay, now here's Claude: ## Summary Fixes a `KeyError` regression introduced by #22906 that breaks `pants check` (and other JVM goals) on lockfiles whose entries reference a transitive dependency that has no top-level coord entry of its own. #22906 bumped Coursier to v2.1.24 to pick up the fix for [coursier#2884](coursier/coursier#2884) and, on the assumption that the only remaining "missing entry" cases would be parent POMs (`classifier="pom"`), simplified `CoursierResolvedLockfile.dependencies()` to do a direct dict lookup instead of an `entries.get(...)` guard. That assumption turns out to be wrong: even fresh resolves with the latest Coursier (verified against v2.1.25-M19) still emit transitive deps without a coord entry — e.g. `("org.apache.curator", "apache-curator", None)` when resolving `org.apache.hive:hive-exec:1.1.0`, or `("org.apache.arrow", "arrow-memory", None)` in the user-reported repro on `hive-exec:3.1.3`. Both have `classifier=None`, so the `if d.classifier != "pom"` filter doesn't catch them, and the unguarded lookup raises `KeyError`. This restores the pre-#22906 `entries.get(...)` skip and adds the bug-report repro as a regression test. ## Changes - `src/python/pants/jvm/resolve/coursier_fetch.py`: restore the `entries.get(...)` guard in `dependencies()`; update the comment to reflect that #2884-style missing entries are still observable on current Coursier. - `src/python/pants/jvm/resolve/coursier_fetch_test.py`: add `test_dependencies_skips_transitive_entries_missing_from_lockfile` — the exact fixture from the bug report. Without the fix it reproduces `KeyError: ('org.apache.arrow', 'arrow-memory', None)`; with the fix it passes. ## Out of scope - `CoursierResolvedLockfile.direct_dependencies()` has the same unguarded pattern but predates #22906; leaving for a follow-up PR. - The longer-term transitive-closure rewrite drafted in `plans/20251117_jvm_transitive_dep_bug.md` is also a follow-up. ## Test plan - [x] New unit test `test_dependencies_skips_transitive_entries_missing_from_lockfile` passes with the fix and fails (with the original `KeyError`) without it. - [x] `./pants test src/python/pants/jvm/resolve/coursier_fetch_test.py src/python/pants/jvm/resolve/coursier_fetch_integration_test.py` — all pass. - [x] `./pants fmt lint check` clean on both changed files. Co-authored-by: Stephen Hopper <stephenmhopper@gmail.com>
tdyas
pushed a commit
that referenced
this pull request
May 20, 2026
…) (regression from #22906) (Cherry-pick of #23341) (#23358) Disclaimer: I used Claude Code to evaluate and confirm comments from #23328. Basically, part of #22906 needs to be reverted. Okay, now here's Claude: ## Summary Fixes a `KeyError` regression introduced by #22906 that breaks `pants check` (and other JVM goals) on lockfiles whose entries reference a transitive dependency that has no top-level coord entry of its own. #22906 bumped Coursier to v2.1.24 to pick up the fix for [coursier#2884](coursier/coursier#2884) and, on the assumption that the only remaining "missing entry" cases would be parent POMs (`classifier="pom"`), simplified `CoursierResolvedLockfile.dependencies()` to do a direct dict lookup instead of an `entries.get(...)` guard. That assumption turns out to be wrong: even fresh resolves with the latest Coursier (verified against v2.1.25-M19) still emit transitive deps without a coord entry — e.g. `("org.apache.curator", "apache-curator", None)` when resolving `org.apache.hive:hive-exec:1.1.0`, or `("org.apache.arrow", "arrow-memory", None)` in the user-reported repro on `hive-exec:3.1.3`. Both have `classifier=None`, so the `if d.classifier != "pom"` filter doesn't catch them, and the unguarded lookup raises `KeyError`. This restores the pre-#22906 `entries.get(...)` skip and adds the bug-report repro as a regression test. ## Changes - `src/python/pants/jvm/resolve/coursier_fetch.py`: restore the `entries.get(...)` guard in `dependencies()`; update the comment to reflect that #2884-style missing entries are still observable on current Coursier. - `src/python/pants/jvm/resolve/coursier_fetch_test.py`: add `test_dependencies_skips_transitive_entries_missing_from_lockfile` — the exact fixture from the bug report. Without the fix it reproduces `KeyError: ('org.apache.arrow', 'arrow-memory', None)`; with the fix it passes. ## Out of scope - `CoursierResolvedLockfile.direct_dependencies()` has the same unguarded pattern but predates #22906; leaving for a follow-up PR. - The longer-term transitive-closure rewrite drafted in `plans/20251117_jvm_transitive_dep_bug.md` is also a follow-up. ## Test plan - [x] New unit test `test_dependencies_skips_transitive_entries_missing_from_lockfile` passes with the fix and fails (with the original `KeyError`) without it. - [x] `./pants test src/python/pants/jvm/resolve/coursier_fetch_test.py src/python/pants/jvm/resolve/coursier_fetch_integration_test.py` — all pass. - [x] `./pants fmt lint check` clean on both changed files. Co-authored-by: Stephen Hopper <stephenmhopper@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.