-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation] implement global waypoints for rotorcraft #1065
Conversation
It looks fine for the rotorcraft part. |
Sure, I can do that... but I was wondering if it is nicer to also create some "getter" functions that compute it on the fly if needed, or just update all possible representations each time a waypoint is updated... |
I was suggesting this since WP are not moved very often, but getter functions are even better |
Added computation of LLA on ENU waypoint set for now. But we should probably still add a getter function that computes it on demand if not already available (e.g. if origin is not already set from flight plan at startup). |
- each waypoint is a struct with multiple representations and flags (e.g. if absolute/global) - factor out waypoints in separate files so it can be shared between firmwares later
3506991
to
b4d1123
Compare
b4d1123
to
6b6d57e
Compare
Added nav_get_waypoint_lla function, that will compute the LLA representation if not already available. |
since users are likely to use this flight plan at their home location, don't add any global waypoints (using lat/lon) that won't be moved by GeoInit
[navigation] implement global waypoints for rotorcraft - if a waypoint is defined with lat/lon instead of x/y in the flight plan, it is marked as an absolute/global waypoint and not moved upon GeoInit - each waypoint is a struct with multiple representations and flags (e.g. if absolute/global) - factor out waypoints in separate files so it can be shared between firmwares later Only for rotorcraft.
A fix without UTM support for this for Fixedwing would be already much better. But probbably e wait for ABI to be finished ? |
This is totally unrelated to ABI. |
Only for rotorcraft so far...