Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation] implement global waypoints for rotorcraft #1065

Merged
merged 5 commits into from
Jan 29, 2015

Conversation

flixr
Copy link
Member

@flixr flixr commented Jan 13, 2015

  • each waypoint is a struct with multiple representations and flags (e.g. if absolute/global)
  • factor out waypoints in separate files so it can be shared between firmwares later
  • if a waypoint is defined with lat/lon instead of x/y in the flight plan, it is marked as an absolute/global waypoint and not moved upon GeoInit

Only for rotorcraft so far...

@flixr
Copy link
Member Author

flixr commented Jan 13, 2015

Basically solves #455 (for rotorcraft) and is a start for #981.
For fixedwings we stilll need to figure out how to best deal with the waypoints in UTM (or even if we keep waypoints in UTM there).

@gautierhattenberger
Copy link
Member

It looks fine for the rotorcraft part.
When updating local waypoints, it would be nice to also compute their global position (based on the state interface ref point), if possible of course.

@flixr
Copy link
Member Author

flixr commented Jan 14, 2015

Sure, I can do that... but I was wondering if it is nicer to also create some "getter" functions that compute it on the fly if needed, or just update all possible representations each time a waypoint is updated...

@gautierhattenberger
Copy link
Member

I was suggesting this since WP are not moved very often, but getter functions are even better

@flixr
Copy link
Member Author

flixr commented Jan 14, 2015

Added computation of LLA on ENU waypoint set for now. But we should probably still add a getter function that computes it on demand if not already available (e.g. if origin is not already set from flight plan at startup).

flixr added 3 commits January 28, 2015 18:06
- each waypoint is a struct with multiple representations and flags (e.g. if absolute/global)
- factor out waypoints in separate files so it can be shared between firmwares later
@flixr flixr force-pushed the absolute_waypoints branch from 3506991 to b4d1123 Compare January 28, 2015 17:21
@flixr flixr force-pushed the absolute_waypoints branch from b4d1123 to 6b6d57e Compare January 28, 2015 17:23
@flixr
Copy link
Member Author

flixr commented Jan 28, 2015

Added nav_get_waypoint_lla function, that will compute the LLA representation if not already available.
@gautierhattenberger do you think this is good to merge as is?
It's only rotorcraft so far, we will need to think about how to handle UTM for fixedwings properly...

since users are likely to use this flight plan at their home location,
don't add any global waypoints (using lat/lon) that won't be moved by GeoInit
@flixr flixr changed the title [navigation] start implementing global waypoints [navigation] implement global waypoints for rotorcraft Jan 29, 2015
flixr added a commit that referenced this pull request Jan 29, 2015
[navigation] implement global waypoints for rotorcraft

- if a waypoint is defined with lat/lon instead of x/y in the flight plan, it is marked as an absolute/global waypoint and not moved upon GeoInit
- each waypoint is a struct with multiple representations and flags (e.g. if absolute/global)
- factor out waypoints in separate files so it can be shared between firmwares later

Only for rotorcraft.
@flixr flixr merged commit a4764de into master Jan 29, 2015
@flixr flixr deleted the absolute_waypoints branch January 29, 2015 20:27
@flixr flixr added this to the v5.6 milestone Jan 29, 2015
@OpenUAS
Copy link
Contributor

OpenUAS commented Mar 31, 2015

A fix without UTM support for this for Fixedwing would be already much better. But probbably e wait for ABI to be finished ?

@flixr
Copy link
Member Author

flixr commented Apr 1, 2015

This is totally unrelated to ABI.
And for fixedwing firmware it has to handle UTM properly, as that is the used navigation coordinate system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants