fix(security): keep rescan icon glued to the scanned-time stamp#327
Merged
Conversation
The Security meta row reads "N risk · … · scanned X ago [↻] [Ignored]". #322 placed the ↻ rescan button right after the "scanned X ago" stamp (reads as "last scanned · refresh"), with only the Ignored entry floating to the list's right edge. #324's meta-row truncate fix gave the stats span `flex-1`, so it ate the full row width and shoved ↻ against the right margin next to Ignored — a large gap opened between the stamp and ↻. Wrap [stats + ↻] in a `flex-1 min-w-0` left group (stats `min-w-0 truncate`, ↻ `flex-none`); Ignored stays an outer `flex-none` sibling. This keeps the no-wrap/truncate behaviour #324 wanted while restoring the stamp↔refresh adjacency. Extends the meta-stability e2e with an adjacency assertion (↻ within 24px of the stamp's right edge) so the gap can't silently reopen. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the Security page meta row, the ↻ rescan button had drifted to the row's far right (next to the Ignored entry), leaving a large gap after the "scanned X ago" stamp. This restores it to sit immediately after the stamp — reading as "last scanned · refresh" — with only the Ignored entry floating to the list's right edge.
Why
#322 deliberately paired ↻ with the stamp (the code comment still says so). #324's meta-row truncate fix then gave the stats
<span>flex-1to stop it wrapping when long — butflex-1made the span consume the full row width, shoving ↻ against the right margin. The intent and the rendered layout diverged; this is a visual regression, not a redesign.How
Wrap
[stats + ↻]in aflex-1 min-w-0left group (stats back tomin-w-0 truncate, ↻flex-none); Ignored stays an outerflex-nonesibling, so it still aligns to the list's right edge. Keeps the no-wrap/truncate behaviour #324 wanted and the stamp↔refresh adjacency #322 wanted.Test plan
security-scan-meta-stability.spec.tswith an adjacency assertion: ↻'s left edge is within 24px of the stamp's right edge (under the regression it was hundreds of px away). The existing during-scan stability assertions are unchanged.🤖 Generated with Claude Code