polish(security): group meta-row actions + let the page fill width#329
Merged
Conversation
Two small alignment fixes on the Security page: - Meta-row actions: move the Rescan ↻ button to the right edge next to the Ignored entry, and drop the Ignored entry's text label so both are icon-only with tooltips — a uniform action cluster. (Supersedes the rescan-adjacent-to-timestamp layout from #327; the stats span's flex-1 pushes the cluster right.) - Width: drop the `max-w-[720px]` cap on the meta row + findings list so the page fills the content width like every other main surface (Shares / Projects / Library), removing the empty right gutter when the sidebar is collapsed. The scanner-unavailable card + empty-state text keep their own readable caps. Tests: - Updated security-scan-meta-stability (drop the now-moot rescan↔stamp adjacency assertion; keep the during-scan no-shift assertion). - Updated security-ignored-entry to assert the icon button's aria-label instead of visible text. - security-blast-radius green — full-width didn't disturb the finding rows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small alignment fixes on the Security page:
flex-1pushes the cluster over.max-w-[720px]cap on the meta row + findings list so Security fills the content width like every other main surface (Shares / Projects / Library), removing the empty right gutter when the sidebar is collapsed.Why
How it connects
SecurityPage.tsx: removes the left-group wrapper (rescan now a sibling in a right-alignedflex gap-1cluster), makes the Ignored button icon-only (w-5 h-5, keepstitle+aria-label), and removes the twomax-w-[720px]caps (meta row + scroll content). The scanner-unavailable card and empty-state copy keep their own readable caps.Test plan
security-scan-meta-stability: drops the now-moot rescan↔timestamp adjacency assertion; keeps the during-scan "rescan button doesn't shift" assertion (still holds — it's right-anchored).security-ignored-entry: asserts the icon button'saria-label(was: visible "Ignored" text).security-blast-radiusgreen — full-width didn't disturb the finding rows.🤖 Generated with Claude Code