Skip to content

polish(security): group meta-row actions + let the page fill width#329

Merged
graydawnc merged 1 commit into
mainfrom
polish/security-meta-action-icons
May 27, 2026
Merged

polish(security): group meta-row actions + let the page fill width#329
graydawnc merged 1 commit into
mainfrom
polish/security-meta-action-icons

Conversation

@graydawnc
Copy link
Copy Markdown
Collaborator

What

Two small alignment fixes on the Security page:

  1. Meta-row actions grouped right. The Rescan ↻ button moves to the right edge next to the Ignored entry, and the Ignored entry loses its "Ignored" text label — both are now icon-only with tooltips, forming a uniform action cluster on the right. The stats span's flex-1 pushes the cluster over.
  2. Page fills width. Drops the max-w-[720px] cap on the meta row + findings list so Security fills the content width like every other main surface (Shares / Projects / Library), removing the empty right gutter when the sidebar is collapsed.

Why

  • The meta row had two visually different action affordances (an icon-only ↻ on the left paired with the timestamp, and a text+icon "Ignored" pill on the right). Grouping both as icon-only on the right reads as one consistent control set.
  • Security was the only main page constrained to 720px; siblings fill the width, so a collapsed sidebar left an unintentional-looking gap. Long finding values / session titles also get more room before truncating.

How it connects

  • SecurityPage.tsx: removes the left-group wrapper (rescan now a sibling in a right-aligned flex gap-1 cluster), makes the Ignored button icon-only (w-5 h-5, keeps title + aria-label), and removes the two max-w-[720px] caps (meta row + scroll content). The scanner-unavailable card and empty-state copy keep their own readable caps.
  • Supersedes the rescan-adjacent-to-timestamp layout from fix(security): keep rescan icon glued to the scanned-time stamp #327 — the timestamp↔refresh adjacency is replaced by the grouped-right cluster.

Test plan

  • security-scan-meta-stability: drops the now-moot rescan↔timestamp adjacency assertion; keeps the during-scan "rescan button doesn't shift" assertion (still holds — it's right-anchored).
  • security-ignored-entry: asserts the icon button's aria-label (was: visible "Ignored" text).
  • security-blast-radius green — full-width didn't disturb the finding rows.
  • app typecheck clean.

🤖 Generated with Claude Code

Two small alignment fixes on the Security page:

- Meta-row actions: move the Rescan ↻ button to the right edge next to
  the Ignored entry, and drop the Ignored entry's text label so both are
  icon-only with tooltips — a uniform action cluster. (Supersedes the
  rescan-adjacent-to-timestamp layout from #327; the stats span's flex-1
  pushes the cluster right.)
- Width: drop the `max-w-[720px]` cap on the meta row + findings list so
  the page fills the content width like every other main surface
  (Shares / Projects / Library), removing the empty right gutter when the
  sidebar is collapsed. The scanner-unavailable card + empty-state text
  keep their own readable caps.

Tests:
- Updated security-scan-meta-stability (drop the now-moot rescan↔stamp
  adjacency assertion; keep the during-scan no-shift assertion).
- Updated security-ignored-entry to assert the icon button's aria-label
  instead of visible text.
- security-blast-radius green — full-width didn't disturb the finding rows.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@graydawnc graydawnc added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit d80b550 May 27, 2026
6 checks passed
@graydawnc graydawnc deleted the polish/security-meta-action-icons branch May 27, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant