feat(share-web): align /me share rows with the desktop Published tab#388
Merged
Conversation
The /me rows and the desktop Shares → Published rows drifted: web kept two always-visible bordered icon buttons per row, an accent-recolor on title hover, and revoked rows mixed into the live list with a red pill and a Copy-link action whose URL is permanently 410. - Row actions collapse into a single hover-revealed ⋯ menu (pinned while open; always visible on touch where hover doesn't exist): Copy link, the new List on profile / Remove from profile toggle (PATCH /api/me/shares/:id — same gates as the desktop menu: listing offered only with a live handle, target-state glyph), and Unpublish. Failures render inline in the menu — the web has no toast surface. - setShareVisibility handles 401 by clearing the auth caches and bouncing to /sign-in, unlike its older peer revokeShare (left as-is here; parity gap noted in the PR). - Revoked shares move into a collapsed "Unpublished · N" section that only renders when history exists, display-only — no dead Copy link. - Title hover keeps its color on /me and /@handle; rows top-align so the trigger pins to the title's first line. - Dead CSS dropped (.sw-share-actions, .sw-pill). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Brings the /me share rows in line with the desktop Shares → Published row design:
:has([aria-expanded]); always visible on touch devices, which have no hover): Copy link (in-place "Copied" confirmation), the new List on profile / Remove from profile toggle, and Unpublish. The toggle calls thePATCH /api/me/shares/:idendpoint shipped in feat(share-backend): PATCH /api/me/shares/:id visibility endpoint #383 with the same gates as the desktop menu — listing offered only when the account has a live handle, icon previews the target state. Failures render inline in the open menu (the web has no toast surface); 401 clears the auth caches and bounces to /sign-in..sw-share-actions,.sw-pill).Why
The two surfaces show the same data and had drifted into different interaction languages. Two always-visible bare icons also read as ambiguous chrome — the menu names each action.
Known gap (intentionally out of scope)
revokeShareshares the pre-existing un-handled-401 behavior thatsetShareVisibilitynow fixes; aligning it touches the unpublish confirm-modal flow and belongs in its own change.Test plan
🤖 Generated with Claude Code