ci: run share-backend and share-web suites in the unit job#392
Merged
Conversation
The unit job covered redact/core/cli/share-kit/app but never share-backend (238 tests) or share-web (70 tests) — flagged in the 2026-06-10 launch audit. Every backend PR since has merged with a green check that never executed its tests. Adds typecheck + test for both packages. share-backend's typecheck had one pre-existing error keeping it red: deletion-worker passed an explicit `cursor: undefined` into R2ListOptions, which exactOptionalPropertyTypes rejects — fixed with a conditional spread. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds four lines to the unit job: typecheck + test for
@spool/share-backend(238 tests) and@spool/share-web(70 tests).share-backend's typecheck had one pre-existing error keeping it red: the deletion worker passed an explicit
cursor: undefinedintoR2ListOptions, whichexactOptionalPropertyTypesrejects. Fixed with a conditional spread — no behavior change.Why
The unit job covered redact/core/cli/share-kit/app but never the two share packages — flagged in the 2026-06-10 launch-readiness audit as the sole CI blocker and not fixed since. Every share-backend PR merged this week carried a green check that never executed its tests; auth, rate-limiting, and deletion-cascade regressions would ship silently. Closing this is a GA precondition.
Test plan
All four new CI commands run locally exactly as CI will: both typechecks clean, 238 + 70 tests green.
🤖 Generated with Claude Code