chore(settings): move Account tab to the top, drop duplicate local-data footer#419
Merged
Merged
Conversation
…ta footer Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small Settings-panel cleanups ahead of the share launch:
sharePublishflag flips, but the flag is build-time (Vite-inlined), so the rail can never shift within a running session — the rationale no longer applies. With sign-in becoming a first-class part of the app, identity belongs at the top. The tab is still hidden in builds withoutVITE_FEATURE_SHAREPUBLISH=1.settings.localData_footerkey is removed from all 7 locales to keep key parity.How
TAB_DEFSreordered; theFooterPathcomponent and its only call site deleted.data-testid="settings-tab-<id>"so tests can address tabs without text-matching (per the e2e selector discipline).Test plan
settings.spec.ts: first rail entry issettings-tab-account, and the sidebar no longer contains the~/.spool/footer probe (locale-independent).settings.spec.ts+ fullshare-publish.spec.ts(Account-tab flow) green locally.🤖 Generated with Claude Code