fix: publish session-kit to npm in the release chain#451
Merged
Conversation
@spool-lab/core and @spool-lab/cli gained a runtime dependency on @spool-lab/session-kit in the v2 share flow, but the Release workflow neither built nor published it — publish-npm failed on the v0.6.0 run (TS2307 in core), and even a successful publish would have shipped a dependency that does not exist on the registry. - release.yml: build session-kit before core, publish it alongside redact/core/cli with the same idempotent skip - release.sh: bump session-kit in lockstep like redact - session-kit: 0.0.1 -> 0.6.0 so its first publish matches the release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 share flow made
@spool-lab/coreand@spool-lab/clidepend on@spool-lab/session-kitat runtime, but the Release workflow neither built nor published it. The v0.6.0publish-npmjob failed with TS2307 inpackages/core; even a green publish would have shipped a dependency that doesn't exist on npm.publish_if_missingguard0.0.1→0.6.0so its first publish matches the already-tagged releaseAfter merge, re-dispatching the Release workflow on
maincompletes the v0.6.0 npm publish (build artifacts + GitHub release already succeeded and re-upload idempotently).