fix(release): fall back to Electron version for native ABI#466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.6.1 Release workflow failed on both hosted runners because
with-electron-native.mjstried to launch Electron only to discoverNODE_MODULE_VERSION. Hosted macOS could not start that probe, so packaging stopped before signing or publication. Add a testednode-abifallback based on the installed Electron version; this is the same ABI registry used by@electron/rebuild.\n\nVerification:\n-pnpm vp check\n-pnpm vp test run scripts/lib/electron-modules-abi.test.mjs\n- forced Electron-start failure through the fullwith-electron-native.mjswrapper caches ABI 148 and exits successfully\n\nNo GitHub release or npm package was created by the failed run. This PR is the v0.6.1 recovery checkpoint.