fix MarkdownParser : correctly parse link url - #11
Merged
AkramZerarka merged 3 commits intoJul 16, 2026
Merged
Conversation
Contributor
|
Thanks for the fix, catching the missing URL on Markdown links is definitely needed, and the assertion in One issue before merge: $link = TextLink::make($linkHref, '', $linkText);
// … then attached to bold, italic, code, etc.For those cases Could you restrict the link to the link branch only? } elseif ($linkText !== '') {
$linkHref = $this->offsetCapture($match, 10);
$style = TextStyle::make()->setUnderline()->setColor('#2563EB');
$paragraph->addRun(new TextRun(
$linkText,
$style,
TextLink::make($linkHref),
));
}Happy to merge once that’s updated. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing MarkdownParser was only getting styles from a link (forgetting the url ... )
=> fixed