Feature: two-factor authentication - #8012
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8012 +/- ##
==========================================
+ Coverage 97.50% 97.52% +0.01%
==========================================
Files 475 475
Lines 19866 20006 +140
Branches 1564 1644 +80
==========================================
+ Hits 19370 19510 +140
+ Misses 496 493 -3
- Partials 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you for working on this @shamoon. I saw that allauth supports WebAuthn (Passkeys) for MFA. Would you consider supporting that in addition to TOTP please? |
stumpylog
left a comment
There was a problem hiding this comment.
Need to test it out too, but a couple minor thoughts
|
Did some testing, all seems to work. Anyway we can customize the name? Mine came across as |
|
Hmm, Im not certain where the name comes from, my 2FA app doesn't really show that. I did try setting the 'issuer': paperless-ngx/src/paperless/settings.py Line 462 in f80e85e otpauth://totp/me%40example.com?secret=PQQ73YEPH3K3QACWY4DHDOZJWMLID5UP&issuer=Paperless-ngx
Is |
stumpylog
left a comment
There was a problem hiding this comment.
Ah, that's the source. I don't set the email when I auto create a user
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details. |
Proposed change
This pretty much entirely uses allauth's handling of totp and just kinda connects it to our frontend.
Closes #424
Type of change
Checklist:
pre-commithooks, see documentation.