fix(library): match Watch streams to active owner profile#139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Nova treated any resumable foreign-owned session as watchable and built the Watch resume mode from client-scoped sync settings. A paused session has no owner stream to join, while a viewer-local mode can differ from the active owner profile and be rejected by Polaris’ strict Watch admission check.
Verification
./gradlew --no-daemon testDebugUnitTest./gradlew --no-daemon -PnovaAbis=arm64-v8a assembleNonRoot_gameDebuggit diff --checkDevice smoke
Verified with two independently paired debug clients: a headless Android emulator as owner and a Retroid Pocket 6 as viewer.
WATCH ACTIVE STREAMwith the owner’s live1920x1080 60fpsprofilemode=1920x1080x60andwatch=1