[logging] Migrate HLE diagnostics to SharpEmuLog#80
Merged
Conversation
Signed-off-by: Digote <45742711+Digote@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModuleManagerdispatch diagnostics through theHLElogger.Aeroliblogger.Why
These diagnostics were written directly to stderr, bypassing the configured
SharpEmu log sinks and file logging. This migration makes HLE and Aerolib
messages consistent with the rest of the structured logging infrastructure.
Validation
dotnet restore SharpEmu.slnx --locked-modedotnet build SharpEmu.slnx -c Release --no-restoredotnet publish src/SharpEmu.CLI/SharpEmu.CLI.csproj -c Release -r win-x64 --self-contained true --no-restorereuse lint