Disable parent project details #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatzElectronics
approved these changes
May 16, 2018
Collaborator
MatzElectronics
left a comment
MatzElectronics
left a comment
There was a problem hiding this comment.
Looks okay - my Java isn't too strong, but as far as I can tell it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing a request for a project record, the app was pulling the project's ancestor project, if one was defined, and performing all of the processing we do to a project record just to obtain a few static fields. It appears that these ancestor or parent fields are not used in the UI and are probably no longer required.
This patch refactors code to add method overrides to support an additional Boolean parameter to enable/disable the ancestor project record data in the JSON payload when retrieving a project record.