Skip to content

Conversation

@zfi
Copy link
Contributor

@zfi zfi commented Jan 30, 2019

#1638 The help link in the drop-down menu on the project editor page is currently pointing to a help system on the BP server that has been redirected to content on learn.parallax.com.

This update corrects the anchor tag in the menu item to point to the help system located on the learn web site.

@zfi zfi self-assigned this Jan 30, 2019
@zfi zfi requested a review from PropGit January 30, 2019 08:33
@zfi
Copy link
Contributor Author

zfi commented Jan 30, 2019

#1641 Deprecated the embedded help system after pointing existing links for online help to the landing page on learn.parallax.com. The affected files will be removed in version 1.3.

Copy link
Contributor

@PropGit PropGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to do this that doesn't require absolute HTTPS:\ call... ie: let the current protocol of the page, and site settings, redirect to HTTPS:\ if need be?

@zfi
Copy link
Contributor Author

zfi commented Jan 30, 2019

The code as constructed opens a new browser tab when it connects to the Learn site. The current browser tab remains connected to the BlocklyProp site with whichever protocol it was using. The Learn site does not support HTTP, so all traffic to the learn site will be redirected to HTTPS regardless of what we set in the source code.

@PropGit
Copy link
Contributor

PropGit commented Jan 30, 2019

Oh yes! Perfect. Thanks for clarifying that.

@PropGit PropGit merged commit 4a572a5 into parallaxinc:1.2 Jan 30, 2019
@zfi
Copy link
Contributor Author

zfi commented Jan 30, 2019

Fixes #1638 Fixes #1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants