Add support for placing the log file on a Windows system. #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored verify_logfile and create_logfile.
|
Nice work, @zfi ! |
|
@zfi - Tested but it failed. I'll point out the problem in code review. |
PropGit
reviewed
Feb 15, 2017
| def __verify_macos_logpath(file_path): | ||
| def __set_windows_logpath(filename): | ||
| user_home = os.path.expanduser('~') | ||
| log_path = user_home + '/AppData/Parallax' |
There was a problem hiding this comment.
@zfi - I failed to notice this when scanning the code, but I see the effects of it in my build and test... It accidentally creates the Parallax subfolder inside the /AppData folder instead of inside the /AppData/Local folder.
When run, the /AppData/Parallax folder is empty (no log file appeared). I don't know if this is because the system somehow let the app create the folder but won't let it populate it, or not.
There was a problem hiding this comment.
NOTE: Retesting shows that the Log File field is blank. So, the plan b to store it in the user's home folder didn't work either?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update add support for placing the event disk log in the user's AppData/Local/Parallax folder or in the user's home directory if the first directory is not available.
Refactored verify_logfile and create_logfile.