add saveAs action with keypress #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
added a commit
that referenced
this pull request
Jun 30, 2015
add saveAs action with keypress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds the ability to Save As from any file using the keypress CTRL-SHIFT-S.
Where should the reviewer start?
Load the branch.
npm run build
How should this be manually tested?
Open a file with some text inside. Ensure you can save with CTRL-S or by clicking the Save button.
Next try to Save As with CTRL-SHIFT-S. You should get a dialog where you can enter a new filename, then press Save As in the dialog. The file should save and navigate you to the new file.
What are the relevant tickets?
Closes #152
Closes #155