Print styles #189
Merged
Print styles #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
It removes the expanded file operations menu labels from appearing when printing.
Where should the reviewer start?
Pull the branch, install and build, and launch editor. The changes are in index.html and plugins/sidebar/index.js
How should this be manually tested?
In the editor, create a file, click the 'plus' button to expand the file menu and then 'cmd-p' or select print. Notice in the print dialog that the preview does not have the labels appearing.
What are the relevant tickets?
closes #181
Screenshots (if appropriate)
This is what it looked like with the problem.
Here is what it looks with the issue resolved.
