add dedupe plugin and source maps for development #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monteslu
added a commit
that referenced
this pull request
Apr 10, 2015
add dedupe plugin and source maps for development
Contributor
|
Thank you for paying attention to file size; it's an important consideration we pay attention to, as can be seen by our PBASIC Tokenizer library/executable size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds the dedupe plugin to reduce file size of
bundle.jsto 3.9mb from 5mb. Also, adds source map generation for development.Where should the reviewer start?
Pull down the changes and rebuild the application.
How should this be manually tested?
Test the features are still working when dependencies are deduped.
Any background context you want to provide?
I thought it would be a good idea to reduce file size before this release.
What are the relevant tickets?
None.