Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 support without py25 #236

Closed

Conversation

@scottkmaxwell
Copy link
Contributor

commented Nov 19, 2013

All of the Py3 support changes updated to remove Python 2.5 support and its ugliness

@Juanlu001

This comment has been minimized.

Copy link

commented Dec 30, 2013

Can we expect a Python 3 compatible release of Paramiko before v2 @bitprophet? Apparently some people are successfully using it (see here and final comments on #16).

@pashinin

This comment has been minimized.

Copy link

commented Jan 3, 2014

Tested it while compiling a changed version of Fabric. +1 for Python 3 version

@pashinin

This comment has been minimized.

Copy link

commented Jan 7, 2014

Well, this pull request passes tests, but it breaks some tests for fabric package. Only when using this version of paramiko.

Here is a log for these tests (python 2.7): https://travis-ci.org/pashinin/fabric/jobs/16505811
You can see that I made only few commits to test it: https://github.com/pashinin/fabric/commits/testp33

I believe @scottkmaxwell can say something helpful.
If you want to test fabric - it has one more dependency - rudolf - https://github.com/pashinin/rudolf

@scottkmaxwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 7, 2014

I haven't used fabric, but it looks like this might be a simple fix. Virtually all of the tests fail with Expected unicode or bytes, got None. May be a single location that needs fixing. Anybody familiar with fabric that can track it down?

@pashinin pashinin referenced this pull request Jan 7, 2014
@dustinfarris

This comment has been minimized.

Copy link

commented Jan 16, 2014

What's blocking this from being merged? Anything I can help with?

@scottkmaxwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2014

@pashinin I found the bug that caused tests to fail with Fabric. I just ran all of the tests with Python 2.7 and they succeed now. Added a new test to Paramiko for this, too.

Merge remote-tracking branch 'master/master' into py3-support-without…
…-py25

Conflicts:
	paramiko/__init__.py
	setup.py
	tests/test_client.py
Fix new test for Py3 and start server in tests instead of in setUp so…
… we can skip starting server for test 5
@scottkmaxwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2014

Latest changes from master have been merged in.

@pashinin

This comment has been minimized.

Copy link

commented Jan 23, 2014

Thanks @scottkmaxwell. Now I have a repeated error from here: https://github.com/scottkmaxwell/paramiko/blob/master/paramiko/sftp_client.py#L581

s.st_size is always 0

I'm not sure what has a bug (my test code for fabric or this branch). Can you confirm that this function was tested and works with py3?

@scottkmaxwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2014

@pashinin Any chance you can step thru the while True loop to see if it is getting an exception?

@lndbrg

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2014

@dustinfarris @scottkmaxwell we are working on getting a new and updated site out first, to be able to communicate a roadmap etc.
After that the next big priority is getting the py3 stuff merged.

@dustinfarris

This comment has been minimized.

Copy link

commented Jan 23, 2014

That's great news! Really looking forward to it. Let me know if I can help with either of those priorities.

@pashinin

This comment has been minimized.

Copy link

commented Jan 24, 2014

@scottkmaxwell Tested. The loop does not give exceptions.
PS: gave a link to a wrong branch (but of course tested yours)

@scottkmaxwell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2014

@pashinin How can I reproduce the problem? I'll have a look.

@pashinin

This comment has been minimized.

Copy link

commented Jan 24, 2014

I guess the problem is in my code. But if you want to help (I'm stuck) - see fabric/fabric#1050 (comment)
I gave links to build logs of fabric.

SebastianDeiss pushed a commit to SebastianDeiss/paramiko that referenced this pull request Feb 4, 2014
Sebastian Deiss
Merged paramiko#236 and added Python3 support for the GSS-API authent…
…icated Key Exchange and user authentication
@michalsladek michalsladek referenced this pull request Feb 10, 2014
@robdennis

This comment has been minimized.

Copy link

commented Feb 16, 2014

Coming to this thread without a lot of context*, I do see http://www.paramiko.org/ does mention a roadmap, but doesn't seem to actually have that roadmap.

I guess that supports what @lndbrg posted earlier: that the next step is to communicate a roadmap, then merge in python 3 support?

* I came to here after looking at where the open stack dependencies were sitting: https://gist.github.com/brettcannon/9009338

@davidhalter

This comment has been minimized.

Copy link

commented Feb 16, 2014

@robdennis There's a statement of @bitprophet about the integration of Python 3 support in #16:

This is still near/at the top of my list, just FYI! need to wrap up a few other bugs & get a set of releases out first.

@bitprophet

This comment has been minimized.

Copy link
Member

commented Mar 7, 2014

#276 now obviates this pull request (is this PR + recent master changes); let's move specific code discussion there (and #16 will remain a higher level "what else needs doing for py3" ticket I guess. LOL at tickets.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.