perf: remove utility-types dependency#10063
Closed
timdeschryver wants to merge 1 commit intoparcel-bundler:v2from
Closed
perf: remove utility-types dependency#10063timdeschryver wants to merge 1 commit intoparcel-bundler:v2from
timdeschryver wants to merge 1 commit intoparcel-bundler:v2from
Conversation
timdeschryver
force-pushed
the
chore/remove-utility-types
branch
from
c153ca1 to
a6826b8
Compare
timdeschryver
changed the title
Member
|
It is actually still used, just not in the source code. When the build converts the types from Flow to TypeScript it gets referenced in the output. https://app.unpkg.com/@parcel/types-internal@2.14.3/files/lib/index.d.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
I want to propose to remove the
utility-typesdependency.As part of the e18e initiative (ecosystem cleanup), we try to reduce the burden of old or big libs and modernize the ecosystem.
We noticed
utility-typesis added as a dependency withinparcel, but it isn't used anymore.With this change we reduce the traffic with 706.92MB a month, whenever it gets installed as part of
@parcel/types-internal.For reference see e18e/ecosystem-issues#137.
💻 Examples
N/A
🚨 Test instructions
N/A
✔️ PR Todo