transactionWatch: Limit the number of active subscriptions and clarify error codes #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
This was referenced Mar 21, 2024
jsdw
reviewed
Mar 21, 2024
jsdw
previously approved these changes
Mar 21, 2024
Co-authored-by: James Wilson <james@jsdw.me>
jsdw
approved these changes
Apr 2, 2024
Contributor
|
This can't be guaranteed, because transactions stay in the pool when a JSON-RPC client disconnects. |
This was referenced Apr 3, 2024
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
This PR ensures that the transaction API generates an `Invalid` events for transaction bytes that fail to decode. The spec mentioned the `Invalid` event at the jsonrpc error section, however this spec PR makes things clearer: - paritytech/json-rpc-interface-spec#146 While at it have discovered an inconsistency with the generated events. The drop event from the transaction pool was incorrectly mapped to the `invalid` event. Added tests for the API stabilize the API soon: - paritytech/json-rpc-interface-spec#144 Closes: #3083 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the server accepts at least 4
transactionWatchsubscriptions, similar to thetransactionBroadcastAPI.While at it, have defined the error codes returned by this API
-38000- more than 4transactionWatchsubscriptions are created (identical error code with chainHead_follow)-32602- Invalid Parameter from the rpc specHave also added a mention wrt invalid decoded transaction bytes in the
Invalidevent.cc @paritytech/subxt-team @tomaka