Revert "Stabilize transactionWatch to version 1"
#148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 602068f.
lexnv
previously approved these changes
Apr 3, 2024
Contributor
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
LGTM!
Just to double-check, we are reverting this because the imposed limit of having at least 4 subscriptions accepted per connection cannot be guaranteed once the transaction enters the pool.
Therefore, we might have situations where the transctionWatch is capped to 4 subscriptions although the same user has more than 4 transactions currently active in the pool.
jsdw
previously approved these changes
Apr 3, 2024
josepot
approved these changes
Apr 3, 2024
Collaborator
|
I resolved the weird conflict in #149 since I can't easily edit fork PRs :) Will close this and merge that if that's all ok! |
jsdw
dismissed stale reviews from lexnv and themself
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #144
#146 is flawed. This shouldn't have been stabilized.