Pin @polkadot-api/json-rpc-provider to 0.2.0 to fix npm build#7
Merged
todortodorovic merged 1 commit intoJun 13, 2026
Merged
Conversation
npm resolves json-rpc-provider 0.0.1 at the root, which lacks the isResponse export used by @polkadot-api/json-rpc-provider-proxy, so `npm run build` fails. The override forces 0.2.0 everywhere. Fixes paritytech/playground-app#323
Contributor
Author
|
@todortodorovic Can you please review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
npm run build(and thereforepg deploy) fails out of the box:npm hoists
json-rpc-provider@0.0.1(pulled in transitively, noisResponseexport) to the root ofnode_modules, while@polkadot-api/json-rpc-provider-proxy@0.4.0importsisResponsewithout declaring a dependency, so it resolves the wrong copy. The repo only ships abun.lock, and bun happens to hoist the working 0.2.0, which is why bun builds pass while every npm build fails.Fix
Add an npm override pinning
@polkadot-api/json-rpc-providerto0.2.0(the latest stable, and the versionpolkadot-api@2.1.6already expects). Verified locally with a red-green setup: clean install fails before the change and builds cleanly after. The legacy consumers of 0.0.1 only import types from it, so the override is safe at runtime.Fixes paritytech/playground-app#323