Migrate pallet-nft-fractionalization to umbrella crate#7970
Merged
bkchr merged 12 commits intoparitytech:masterfrom Apr 11, 2025
Merged
Migrate pallet-nft-fractionalization to umbrella crate#7970bkchr merged 12 commits intoparitytech:masterfrom
bkchr merged 12 commits intoparitytech:masterfrom
Conversation
48 tasks
re-gius
added
R0-no-crate-publish-required
re-gius
reviewed
Apr 2, 2025
Contributor
re-gius
left a comment
re-gius
left a comment
There was a problem hiding this comment.
The changes overall look good, but there are some extra spaces here and there to remove (see also CI errors or try to do cargo check locally)
re-gius
reviewed
Apr 2, 2025
Contributor
|
Review required! Latest push from author must always be reviewed |
re-gius
requested changes
Apr 3, 2025
Contributor
Author
|
cargo fmt --check has ran successfully without any errors |
bkchr
requested changes
Apr 3, 2025
kR1s0147
force-pushed
the
migrate-nft-fractionalisation-to-umbrella
branch
2 times, most recently
from
20d4074 to
4f79ecb
Compare
Contributor
|
Please run |
Contributor
Author
|
have committed the changes |
kR1s0147
force-pushed
the
migrate-nft-fractionalisation-to-umbrella
branch
from
b45fff2 to
8d31e2b
Compare
Contributor
|
I think you just need to undo the changes to the |
Contributor
Author
|
i have ran it on "polkadot-sdk/substrate/frame/nft-fractionalization" so it showed errors on taplo formatting errors and now i have ran it in polkadot-sdk/ |
bkchr
approved these changes
Apr 11, 2025
Merged
via the queue into
paritytech:master
with commit Apr 11, 2025
6ce6110
233 of 243 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6504