fix(sync): avoid node ban after justification error UnknownTargetBlock#3257
Merged
Conversation
After warp sync finishes, the non finalized tree contains just the warp-sync target block. The node now needs to catch up from that target to the chain tip. During that window, peers will send justifications targeting blocks the local node hasn't yet downloaded. Not banning the node avoid delaying into receving important data needed to continue the sync.
skunert
approved these changes
May 21, 2026
Merged
lrubasze
added a commit
that referenced
this pull request
Jun 1, 2026
This is to: - publish `smoldot-v3.1.4` npm. - publish crates `smoldot-light v1.1.4`, `smoldot v1.1.3` ## Changes ### Changed - Revert the immediate parachain block delivery introduced in 3.1.3. ([#3267](#3267)) - Decide the parachain bootstrap mode up front so `chainHead_v1_follow` subscribers receive an authoritative finalized block instead of a stale chain-spec checkpoint. ([#3268](#3268)) - Prefer chain-spec bootnodes for relay-chain gossip slots until a chain has an open gossip link, speeding up the first relay-chain gossip after a warm restart. ([#3273](#3273)) - Shorten handshake and peer-ban timeouts to speed up peer discovery after a restart. ([#3269](#3269)) ### Fixed - Fix \`forbidNonLocalWs\` auto-detection in browsers, which previously never forbade non-local WebSocket connections on secure origins. ([#3262](#3262)) - Avoid banning peers that send justifications targeting not-yet-downloaded blocks during post-warp-sync catch-up, removing sync delays. ([#3257](#3257)) - Floor the statement-distribution affinity bloom filter size so sparse topic subscriptions still produce a realistically-sized filter. ([#3265](#3265))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After warp sync finishes, the non finalized tree contains just the warp-sync target block. The node now needs to catch up from that target to the chain tip. During that window, peers will send justifications targeting blocks the local node hasn't yet downloaded.
Not banning the node avoids delays in receiving important data needed to continue the sync.
This has been extracted from paritytech/smoldot-archive#2222, but not being relevant only to WebRTC, it has been moved into its own pr.