Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

authorities_at cache update#836

Merged
gavofyork merged 3 commits intomasterfrom
authorities_at_cache_upd
Oct 9, 2018
Merged

authorities_at cache update#836
gavofyork merged 3 commits intomasterfrom
authorities_at_cache_upd

Conversation

@svyatonik
Copy link
Copy Markdown
Contributor

closes #765

Besides non-instant finality support, there's also:

  • several list-based caches can now share single db column (we'll need cache ":code" on light clients for sure);
  • extracted cache-related source to the separate folder - there's too much code (especially tests) for single file.

The cache itself will behave optimal (without any db-requests), when:

  • either we work with instant-finality consensus;
  • or there are no forks in post-finalized blocks.

Otherwise, some additional lookups are performed when block is inserted/finalized or value is queried from the cache. Cache supports pruning entries for old finalized blocks. Cache destroys 'abandoned' unfinalized forks (i.e. forks that have forked before best finalized block).

@svyatonik svyatonik added the A0-please_review Pull request needs code review. label Sep 28, 2018
@gavofyork gavofyork added A6-seemsok and removed A0-please_review Pull request needs code review. labels Oct 5, 2018
@gavofyork gavofyork merged commit 720afa0 into master Oct 9, 2018
@gavofyork gavofyork deleted the authorities_at_cache_upd branch October 9, 2018 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle reorganizations in light client cache

2 participants