-
Notifications
You must be signed in to change notification settings - Fork 73
TrieDBMutBase added: no commit on drop
#226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| [package] | ||
| name = "trie-db" | ||
| version = "0.30.0" | ||
| version = "0.31.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I generally prefer having a dedicated "chore" release PR with no/minimal changes, we'll also need to add this PR to the trie-db changelog 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, just copied the "modus operandi" from some other commit in this repo :), which makes a change and bumps version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that works too, proly need a few more bumps? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lexnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we can add the release to a dedicated PR and tiny question around the root ++ commit op 🙏
lexnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🙏
bkchr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks. Otherwise should be fine as it doesn't change the default behavior.
|
Uploaded crates: New tags: |
This PR adds an option to prevent
TrieDBMutfrom committing implicitly on drop.This PR extends the
TrieDBMutimplementation to provide better control over when changes are committed to the database.Changes:
commit_on_dropflag added toTrieDBMut,without_commit_on_dropmethod toTrieDBMutBuilderwhich configures the builder to create a non-commitingTrieDBMutinstance for cases where commit on drop is undesired.Part of: paritytech/polkadot-sdk#6020