Fixed exception handling in EventuallyPin.findAllPinned()

[cjosepha]

No description provided.

[flovilmart]

Do you have a reference of something that would help iOS understand the change?

[cjosepha]

iOS?

[flovilmart]

Us. Sorry stupid autocorrect

[cjosepha]

The code in the callback starting at L172 doesn't check if the task is faulted, and assumes it's successful by iterating over the result's list.
So there is a potential null pointer exception at L175.
Also in other parts of the sdk onSuccessTask was used for the same case :

Parse-SDK-Android/Parse/src/main/java/com/parse/ParsePinningEventuallyQueue.java

Line 583 in e86b920

return EventuallyPin.findAllPinned().onSuccessTask(new Continuation<List<EventuallyPin>, Task<Void>>() {

[codecov]

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #837   +/-   ##
=========================================
  Coverage     54.24%   54.24%           
  Complexity     1697     1697           
=========================================
  Files           123      123           
  Lines          9783     9783           
  Branches       1371     1371           
=========================================
  Hits           5307     5307           
  Misses         4042     4042           
  Partials        434      434

Impacted Files	Coverage Δ	Complexity Δ
Parse/src/main/java/com/parse/EventuallyPin.java	0% <0%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76df4ae...6aaa454. Read the comment docs.

[coveralls]

Coverage remained the same at 58.694% when pulling 6aaa454 on DanGTZ:master into 76df4ae on parse-community:master.

[cjosepha]

@flovilmart does my explanation helped you? No problem to close the pull request if you don't want this improvement.

[cjosepha]

@flovilmart I can see the "codecov/patch" check failed, what can I do to solve this?

[flovilmart]

This means that the changes (patch) are not covered by a test at all.