Fix deadlock in WinRT platform utils when AppName is accessed from the main thread. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse/PlatformHooks.WinRT.cs
Outdated
|
Single nit, otherwise - lgtm. |
…e main thread. This could happen because by default, `await` continues on the thread it was invoked from, in this case, the main thread, which is blocked on the line below. Fixes #26.
richardjrossiii
force-pushed
the
richardross.platformhooks.awaitdeadlock
branch
from
af0d8a4 to
7febb14
Compare
richardjrossiii
added a commit
that referenced
this pull request
Oct 9, 2015
…waitdeadlock Fix deadlock in WinRT platform utils when AppName is accessed from the main thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen because by default,
awaitcontinues on the thread it was invoked from, in this case, the main thread, which is blocked on the line below.Fixes #26.
cc @hallucinogen @grantland